Use communication channel to notify about the websocket closed #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msarvar
force-pushed
the
fix-log-streaming
branch
from
376b663 to
b04388e
Compare
msarvar
added a commit
that referenced
this pull request
Oct 18, 2021
* So for whatever reason tf show with big plan doesn't work in async * rename isValidCommand to isAsyncEligibleCommand
Aayyush
pushed a commit
that referenced
this pull request
Dec 9, 2021
* So for whatever reason tf show with big plan doesn't work in async * rename isValidCommand to isAsyncEligibleCommand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround the blocking async execution. At the moment, when we run a terraform show on a particularly big plan output, bufio will block the execution in
Scanphase. This is due toScanreading one newline at a time but also having a buffer limit of 64kb. So when a single line is bigger than the buffer it will hang. Since this is only happens with terraform show, we will just move ourisAsyncEligibleCommandcheck before we execute the async function.